Deps: significantly improve compilation times by removing the futures crate
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, using the `futures-channel` crate over the `futures` crate causes compilation errors. This is very strange because the `futures::channel` module from the `futures` crate is literally just re-exported from the `futures-channel` crate! Despite this, the code fails to compile whenever I use `futures-channel` instead. As a temporary workaround, we use the full `futures` crate in the tests. However, when the user downloads the crate, they will still get the minimal sub-crates (not the full `futures` crate).
BastiDood
commented
May 18, 2022
|
Strange that the GitHub Actions for this PR ran longer than usual. But I can assure you that there have been significant improvements when I ran the workflows in my fork. In particular, the |
|
Thank you, this look great! 😄 I didn't know I'll give this a proper review later today. |
MattiasBuelens
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve compilation times by minimizing our dependency on the heavy
futurescrate, which compiles thefutures-executorcrate by default. In my fork, the same GitHub Actions workflows dropped by ~20 seconds. This is great!I did face some really strange issues that required temporary workarounds with theUpdate: see #11 (comment).devDependencies. But as far as the user is concerned, they should not be affected by these changes. More on that in a separate review comment.Besides that, everything should be alright! 👍