Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usage in web workers #14

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Support usage in web workers #14

merged 3 commits into from
Oct 15, 2022

Conversation

MattiasBuelens
Copy link
Owner

This removes all usages of JavaScript snippets in the code, so the crate can also be used in web workers (where such snippets aren't available).

This is done by reverting 67bb2a4 (Work around Chromium bug with { type: "bytes" }). Since Chromium bug #1187774 was fixed upstream a while ago, there's no need to keep this workaround in the code.

Fixes #13.

@MattiasBuelens MattiasBuelens added the bug Something isn't working label Oct 15, 2022
@MattiasBuelens MattiasBuelens self-assigned this Oct 15, 2022

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
This reverts commit 67bb2a4.
@MattiasBuelens MattiasBuelens added this to the v0.3.0 milestone Oct 15, 2022
@MattiasBuelens MattiasBuelens merged commit cae07fd into master Oct 15, 2022
@MattiasBuelens MattiasBuelens deleted the remove-js-snippets branch October 15, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate is not supported in web workers due to js-snippets usage
1 participant