Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support readable byte streams #6

Merged
merged 35 commits into from
Jun 22, 2021
Merged

Support readable byte streams #6

merged 35 commits into from
Jun 22, 2021

Conversation

MattiasBuelens
Copy link
Owner

@MattiasBuelens MattiasBuelens commented Jun 21, 2021 •
edited
Loading

  • Add ReadableStream::(try_)get_byob_reader to acquire a BYOB reader.
  • Add ReadableStream::from_async_read to turn an AsyncRead into a readable byte stream.
  • Add ReadableStream::(try_)into_async_read to turn a readable byte stream into an AsyncRead.

@MattiasBuelens
Rename ReadableStreamReadResult to ReadableStreamDefaultReadResult
231f5f6
@MattiasBuelens
Add basic support for byte streams and BYOB readers
03bf09a
@MattiasBuelens
Add read_with_buffer to avoid allocations on repeated reads
8db277e
@MattiasBuelens
Add sys::ReadableStreamGenericReader to deduplicate some glue code
4dc658e
@MattiasBuelens
Fix typo
3813e2c
@MattiasBuelens
Move readers to separate modules
d38b509
@MattiasBuelens
Fix reader constructors
1351f3b
@MattiasBuelens
Simplify error handling
9043257
@MattiasBuelens
Simplify writer construction
7b6fe9a
@MattiasBuelens
Fix missing import for docs
8a1edcf
@MattiasBuelens
Add ReadableStream.into_async_read()
e86dbbe
@MattiasBuelens
Fix "unused imports" warning
646c0d6
@MattiasBuelens
Extract helper
86bdc9b
@MattiasBuelens
Remove unnecessary as_mut() and as_ref() calls
9bcfe48
@MattiasBuelens
Add ReadableStream::from_async_read
2b5baf2
@MattiasBuelens
Work around Chromium bug with { type: "bytes" }
67bb2a4
@MattiasBuelens
Ensure we don't accidentally use the unsafe view longer than needed
2cb459c
@MattiasBuelens
Clamp buffer lengths to u32
b4e4811
@MattiasBuelens
Try to convert JS errors into std::io::Error
8f4ac69
@MattiasBuelens
More tests
fb9be05
@MattiasBuelens
Simplify
159b2a5
@MattiasBuelens
Test aborting a BYOB read
b65c326
@MattiasBuelens
Test aborting a BYOB read with from_async_read
404a455
@MattiasBuelens
Tweak
e6e813a
@MattiasBuelens
Simplify IntoUnderlyingByteSource::pull
f2a9fdc
@MattiasBuelens
Handle BYOB reads that do not fill entire buffer
df61946
@MattiasBuelens
Simplify
b3f95f5
@MattiasBuelens
Check casts between u32 and usize
ae2373e
@MattiasBuelens
Test reading into smaller buffer
74c65cc
@MattiasBuelens
Rename length to len
64d7e15
@MattiasBuelens MattiasBuelens added the enhancement New feature or request label Jun 21, 2021
@MattiasBuelens MattiasBuelens self-assigned this Jun 21, 2021
@MattiasBuelens
Handle BYOB reader returning { done: true, value: undefined }
ea6a338 
When the stream is canceled, pending reads are now immediately resolved
without waiting for the buffer to be returned to the caller.

whatwg/streams@8a7d92b
@MattiasBuelens
Fix clippy warnings
3d1dde2
@MattiasBuelens MattiasBuelens merged commit 6a5cc65 into master Jun 22, 2021
@MattiasBuelens MattiasBuelens deleted the byte-streams branch June 22, 2021 19:21
@MattiasBuelens MattiasBuelens added this to the v0.2.0 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MattiasBuelens MattiasBuelens

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@MattiasBuelens