Inline all content previews #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make them inline, so when you have `look here (some content link)` it does not get converted to: ``` look here ( some content preview ) ``` - fix links getting completely removed. The cause was the link-matching in the `ApActivityRepository` which sometimes returned an object with `0` as the id which of course does not yield results from the DB. Since that was just not expected we showed an empty div for these links
BentiGorlich
added
bug
|
See it in action as well here: https://kbin.melroy.org/m/testing/t/728880/Test-markdown It does seem to work now indeed! Thanks. It only doesn't work when the span is too large like a big title or something. Then the span will just be too large and cause the text to wrap anyways (or even the inside text in the span will wrap). |
melroy89
previously approved these changes
Mar 28, 2025
melroy89
reviewed
Mar 28, 2025
melroy89
reviewed
Mar 28, 2025
melroy89
reviewed
Mar 28, 2025
melroy89
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
look here (some content link)it does not get converted to:look here ( some content preview )ApActivityRepositorywhich sometimes returned an object with0as the id which of course does not yield results from the DB. Since that was just not expected we showed an empty div for these linksCloses #1493