-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper generation to CI builds #86
Conversation
It should be noted that Ubuntu 20.04 LTS (supported until April 2025) uses Qt 5.12. So ensuring PythonQt works with 5.9, 5.12, 5.15 would be nice. Also, CentOS 7/8/9 and Ubuntu 18.04/20.04/22.04 offers QtWebKit as supported package even though Qt company no longer supports it (since Qt 5.7). QtWebKit is developed and supported by the old developer of it and open-source team. It would be cool if the pre-generated headers shipping with PythonQt did include the QtWebKit interface. This could be done by ensuring QtWebKit package is installed on the corresponding platform before generating the interface files. |
Common long-term support production platforms in active support window:
|
As for qmake, referenced in issue linked above, it would indeed be great as you say to keep qmake support for Qt 5 as I am sure many projects using Qt 5 will not switch build system when nothing is broken (and changing build system is major work). Qt 5.15 will continue to be used for at least another decade or longer given its active support window on production/enterprise platforms. Neither RH nor Canonical is shipping a long-term supported distribution with Qt 6 yet. |
I was going to replace the GCC images with standard Ubuntu images anyway, so this will replace Qt 5.11 with Qt 5.12. As for QtWebKit - you could make a PR that adds it at least to the CI images - you probably know how to install it under CentOS and Ubuntu. |
013e0ea
to
33daff9
Compare
I could clone the latest code and look into a full PR. However, it would be a one-liner installing the package. The package is qt5-qtwebkit-devel on RHEL/CentOS/Rocky (from EPEL) and libqt5webkit5-dev on Ubuntu. So
on RHEL/CentOS/Rocky, and
on Ubuntu. |
@he-hesce - thanks, I can add this to the dockerfiles! While at this: maybe you have an idea why the Ubuntu 22.04 build currently fails? It doesn't find |
@mrbean-bremen: See issue #81 (22.04 has Python 3.10 while 20.04 has Python 3.8 and some header files were relocated) |
Ah right, of course - I had somehow missed that this is the same issue... Thanks! |
1bd36ce
to
a74111a
Compare
- also remove unneeded "pydebug.h" include -> fixes MeVisLab#81
a74111a
to
345a7b4
Compare
No checks are currently made that the wrappers are generated correctly, but the generator output can be checked for problems. Note that the generator for 5.15 still has a lot of warnings and generates less wrappers compared to 5.11 (running on gcc7).
For comparison the number of wrappers generated as logged by the generator: