Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registering custom 'meteor' scheme #39

Merged

Conversation

ramijarrar
Copy link

@ramijarrar ramijarrar commented Jan 17, 2024

What

Fixes registering the custom meteor:// protocol which is used to serve assets locally.

Why

The current implementation uses streams but does not specify the appropriate flag during registration.

From the Electron 17 docs (https://github.com/electron/electron/blob/v17.4.11/docs/api/protocol.md):

Protocols that use streams (http and stream protocols) should set stream: true. The <video> and <audio> HTML elements expect protocols to buffer their responses by default. The stream flag configures those elements to correctly expect streaming responses.

Without specifying the stream flag, any larger files (>64kb of buffered data) in the public directory will not be loaded.

@StorytellerCZ StorytellerCZ merged commit ac91eb8 into Meteor-Community-Packages:master Aug 19, 2024
@StorytellerCZ
Copy link
Member

Released in @meteor-community/meteor-desktop@3.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants