Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wastewater estimates 2005-2021 #106

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

pawilfahrt
Copy link
Collaborator

@pawilfahrt pawilfahrt commented Jul 11, 2024

Checklist

Please complete this checklist as a courtesy to the PR reviewer.

Code and styling

  • All of the files/scripts I added are in the right place and named appropriately. See the README for details.
  • I have not used setwd()
  • I have used file.path(here::here(), "file_name")) to source any scripts or read in data
  • I have not added any large datasets, unless absolutely necessary (explain)
  • I have commented my code, particularly in hard to understand areas
  • I have added additional package dependencies as necessary with renv::install()
  • I have run styler::style_dir(".", recursive = TRUE, filetype = c("R", "qmd"))
  • Plots
    • If plotly, use source = "chunk-name" in plot_ly()
    • Use formatting with councilR::plotly_layout()?
  • Chunk formatting
    • All chunks named
    • All figure or table chunks have caption
    • out.width: "95%". If a specific height is needed, use pixels. and/or out.height: "500px"

Document editing

  • I have ensured that modified documents knit successfully from render_for_publication.R
  • I have fixed any missing citations, cross references, hyperlinks
  • I have reviewed my contributions for typos and misspellings.

GitHub and project management

  • I have identified and assigned at least one Reviewer (Liz, Sam, Laine) to this PR
  • I have assigned myself to this PR
  • I have updated the status in the GitHub Project

@pawilfahrt pawilfahrt added the waste_wastewater Solid waste and wastewater label Jul 11, 2024
@pawilfahrt pawilfahrt requested a review from mcnamx July 11, 2024 02:59
@pawilfahrt pawilfahrt self-assigned this Jul 11, 2024
Copy link
Collaborator

@mcnamx mcnamx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few formatting changes, I think this is good to go!

@pawilfahrt pawilfahrt merged commit 8fd7281 into dev-2005-baseline Jul 11, 2024
@pawilfahrt pawilfahrt deleted the 78-wastewater-data-sourcing-2005 branch July 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waste_wastewater Solid waste and wastewater
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants