Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imageUpdateInterval #386

Merged
merged 6 commits into from
Nov 13, 2024
Merged

add imageUpdateInterval #386

merged 6 commits into from
Nov 13, 2024

Conversation

mcsdodo
Copy link
Contributor

@mcsdodo mcsdodo commented Nov 10, 2024

  • make image update checking opt-in.
  • split logic for container updates and image updates

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Congratulations on your first pull request! We are excited to review your contribution to the project.

@SiriosDev
Copy link
Contributor

SiriosDev commented Nov 10, 2024

  • split logic for container updates and image updates

can i ask what do you mean with the distinction between container updates and image updates?

  • make image update checking opt-in.

And also what do you mean by update interval?

@mcsdodo
Copy link
Contributor Author

mcsdodo commented Nov 10, 2024

A Docker container is a self-contained, runnable software application or service. On the other hand, a Docker image is the template loaded onto the container to run it, like a set of instructions.

I split logic of reporting state of running container (status/uptime/created etc.) and checking update of the image (newer version).

@SiriosDev
Copy link
Contributor

SiriosDev commented Nov 10, 2024

I split logic of reporting state of running container (status/uptime/created etc.) and checking update of the image (newer version).

in short terms every x minute check the "vitals" and every y minutes check "update"?

@mcsdodo
Copy link
Contributor Author

mcsdodo commented Nov 10, 2024

exactly. Because I run many containers in my homelab I was running in 429 - and the app didn't respond to this properly, causing too much CPU usage in infinite exceptions handling.

@mcsdodo mcsdodo closed this Nov 10, 2024
@mcsdodo mcsdodo reopened this Nov 10, 2024
@MichelFR
Copy link
Owner

Thanks for your contribution!

I think we should probably rename some of the variables here, seems to be somewhat confusing.

ContainersMessages
ContainerMessage
ContainerMessages
ContainersMessage

We should also probably have a fallback if a user does not have a imageUpdateInterval set we set automatically take the default updateInterval so we dont have any breaking changes. We should also update the readme.md.

@MichelFR MichelFR added the enhancement New feature or request label Nov 11, 2024
@mcsdodo
Copy link
Contributor Author

mcsdodo commented Nov 11, 2024

done

@MichelFR MichelFR merged commit 934357b into MichelFR:main Nov 13, 2024
2 checks passed
SiriosDev added a commit to SiriosDev/MqDockerUp that referenced this pull request Nov 16, 2024
…nfs naming for a better consistency (with deprecation warn for main ones)
SiriosDev added a commit to SiriosDev/MqDockerUp that referenced this pull request Nov 16, 2024
…lowing the separation of functions implemented in MichelFR#386
SiriosDev added a commit to SiriosDev/MqDockerUp that referenced this pull request Nov 28, 2024
…nfs naming for a better consistency (with deprecation warn for main ones)
SiriosDev added a commit to SiriosDev/MqDockerUp that referenced this pull request Nov 28, 2024
…lowing the separation of functions implemented in MichelFR#386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default timeout of 60 (milliseconds) causes connack timeout Too many requests: Rate limit exceeded
3 participants