-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add imageUpdateInterval #386
Conversation
mcsdodo
commented
Nov 10, 2024
- make image update checking opt-in.
- split logic for container updates and image updates
… container and image updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Congratulations on your first pull request! We are excited to review your contribution to the project.
can i ask what do you mean with the distinction between container updates and image updates?
And also what do you mean by update interval? |
I split logic of reporting state of running container (status/uptime/created etc.) and checking update of the image (newer version). |
in short terms every x minute check the "vitals" and every y minutes check "update"? |
exactly. Because I run many containers in my homelab I was running in 429 - and the app didn't respond to this properly, causing too much CPU usage in infinite exceptions handling. |
Thanks for your contribution! I think we should probably rename some of the variables here, seems to be somewhat confusing. ContainersMessages We should also probably have a fallback if a user does not have a imageUpdateInterval set we set automatically take the default updateInterval so we dont have any breaking changes. We should also update the readme.md. |
done |
…nfs naming for a better consistency (with deprecation warn for main ones)
…lowing the separation of functions implemented in MichelFR#386
…nfs naming for a better consistency (with deprecation warn for main ones)
…lowing the separation of functions implemented in MichelFR#386