Add the ability to add extra containers to the Pihole pod #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I merged another PR before yours. Thank you for your contribution, it looks good to me. |
|
No worries. I bumped the version up another notch. Hope I'm doing this right. |
|
Ha, now I screwed up the merge by adding trailing whitespaces :) Don't ask me if you doning it right when I can't do it right in the first place ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a container that I use to run a process to monitor the Pihole logs for specific DNS queries. The container uses a shared volume created on /var/log/pihole. I currently cannot use this Helm chart because there is no way to add my own container.
This pull request simply adds the ability to add any number of containers via values.yaml.
It passes LINT and I was able to successfully run my fork of the Helm chart to get my secondary container running within the Pihole pod.
This is my first ever contribution to any Github project. Please be gentle, but feedback is appreciated. :)