Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated pihole exporter to v1.0.0 #351

Merged
merged 8 commits into from
Mar 8, 2025
Merged

Conversation

frittenlab
Copy link
Contributor

Description of the change

This change updates the pihole exporter to v1.0.0. This makes the exporter compatible with the latest pihole version

Benefits

The exporter will be able to export metrics via the new API path

Possible drawbacks

None

Checklist

@auto-assign auto-assign bot requested a review from MoJo2600 March 4, 2025 15:57
@frittenlab frittenlab changed the title updated pihole exporter to v1.0.0 fix: updated pihole exporter to v1.0.0 Mar 4, 2025
Copy link
Owner

@MoJo2600 MoJo2600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoJo2600
Copy link
Owner

MoJo2600 commented Mar 8, 2025

Sorry for the lots of commits, but I thought I was going crazy... Turns out there was an issue in the current version of the chart which causes this pr to fail all the time -.-

@MoJo2600 MoJo2600 merged commit 04d4e90 into MoJo2600:main Mar 8, 2025
2 checks passed
@bergpb bergpb mentioned this pull request Mar 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants