wraps all files that rely on browser window or document in a conditional #600
+7,800
−7,753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSwitch
reviewed
Apr 23, 2019
|
|
||
| // No form | ||
| form: false | ||
| if (typeof window !== 'undefined') { |
There was a problem hiding this comment.
Not the whole module relies on this.
There was a problem hiding this comment.
Would it be better to take this one out then?
I think I saw the reference to window.navigator.userAgent on line 32 and assumed it would throw an error if window wasn't present.
Co-Authored-By: berkeleycole <berkeleycole@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the library doesn't error out if browser window or document are not available, making it easier to use for people building static sites or using SSR