This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Save LN peer metadata to indexedDB #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
save-some-gossip
branch
5 times, most recently
from
23495cf to
908e12e
Compare
benthecarman
commented
Apr 14, 2023
|
needs rebase |
AnthonyRonning
suggested changes
Apr 14, 2023
src/node.rs
Outdated
| @@ -385,24 +392,31 @@ impl Node { | |||
| continue; | |||
| } | |||
|
|
|||
| let peer_connections = connect_persister.list_peer_connection_info(); | |||
| let peer_connections = get_all_peers().await.unwrap_or_default(); | |||
There was a problem hiding this comment.
Isnt this going to pull in peers that all nodes have saved?
There was a problem hiding this comment.
yes but on line 401 we filter out ones that our node isn't included in
benthecarman
force-pushed
the
save-some-gossip
branch
from
d8bf270 to
5900c73
Compare
Comment on lines
955
to
971
| pub async fn list_peers(&self) -> Result<Vec<MutinyPeer>, MutinyError> { | ||
| let nodes = self.nodes.lock().await; | ||
| let peer_data = gossip::get_all_peers().await?; | ||
|
|
||
| // get peers saved in storage | ||
| let mut storage_peers: Vec<MutinyPeer> = nodes | ||
| let mut storage_peers: Vec<MutinyPeer> = peer_data | ||
| .iter() | ||
| .flat_map(|(_, n)| n.persister.list_peer_connection_info()) | ||
| .map(|(pubkey, connection_string)| MutinyPeer { | ||
| pubkey, | ||
| connection_string, | ||
| .map(|(node_id, metadata)| MutinyPeer { | ||
| // node id should be safe here | ||
| pubkey: secp256k1::PublicKey::from_slice(node_id.as_slice()) | ||
| .expect("Invalid pubkey"), | ||
| connection_string: metadata.connection_string.clone(), | ||
| alias: metadata.alias.clone(), | ||
| color: metadata.color.clone(), | ||
| label: metadata.label.clone(), | ||
| is_connected: false, | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Wait this could just be a side effect with a bug (or not intended behavior) with our existing API. We're just doing a normal list_peers, but perhaps we should change the API to indicate a specific node and the peers that node should be connected to?
AnthonyRonning
approved these changes
Apr 14, 2023
|
needs rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the peer connection info to indexedDB.
TODO: