Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastx client] Synchronise certificates with authorities before making move call and publish #252

Closed
patrickkuo opened this issue Jan 23, 2022 · 4 comments · Fixed by #285 or #378
Closed
Assignees

Comments

@patrickkuo
Copy link
Contributor

We should make sure the authorities have all the necessary certificates before making move call, like how it's done in communicate_transfer

@gdanezis
Copy link
Collaborator

The issue here is related to this issue: #290

@gdanezis gdanezis reopened this Jan 30, 2022
@gdanezis
Copy link
Collaborator

This issue was closed by mistake :(

@patrickkuo
Copy link
Contributor Author

The sync should be working for move calls and publish after this refactoring #269, however this is still using sequence number determine the missing certificates, which is incorrect, stated in this issue #290

@gdanezis
Copy link
Collaborator

Yep, I will next go in and try to fix all this using the sync functions we just build as well as more local state that we now have at hand. In terms of local state what would be very useful is:

  • the Objects involved in an order, which contain the parent_transaction.
  • a map of certs by digest, that we can use as a local cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment