[fastx client] Refactored transfer_object/move_call/push to use execute_transaction #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
force-pushed
the
pat/client-error-handling
branch
from
e09e762 to
87955be
Compare
patrickkuo
force-pushed
the
pat/client-refactoring
branch
3 times, most recently
from
704485d to
04ce530
Compare
* bug fix: execute_transfer will not be able to execute twice if previous request failed, causing `pending_transfer` to stick.
…ransfer_object * Added From<anyhow::Error> for FastPayError * some refactoring
* new test for receive_object * new error for incorrect recipient
…on`, added `execute_transaction_without_confirmation` to simplify the code
patrickkuo
force-pushed
the
pat/client-refactoring
branch
from
04ce530 to
5d8638f
Compare
patrickkuo
requested review from
oxade,
gdanezis,
sblackshear,
arun-koshy,
awelc,
huitseeker and
lxfind
|
LGTM, but I'm biased because I want this to go in asap, so I'll let others review :) |
lxfind
reviewed
Jan 26, 2022
fastpay_core/src/client.rs
Outdated
| @@ -250,16 +251,16 @@ impl<A> Requester for CertificateRequester<A> | |||
| where | |||
| A: AuthorityClient + Send + Sync + 'static + Clone, | |||
| { | |||
| type Key = SequenceNumber; | |||
| type Key = (ObjectID, SequenceNumber); | |||
| type Value = Result<CertifiedOrder, FastPayError>; | |||
|
|
|||
| /// Try to find a certificate for the given sender and sequence number. | |||
fastpay_core/src/client.rs
Outdated
| errors: error_scores.into_keys().collect(), | ||
| }) | ||
| } | ||
|
|
||
| async fn communicate_transfers( | ||
| /// Broadcast confirmation orders and execute handle order. |
There was a problem hiding this comment.
I don't fully understand this comment. What does "execute handle order" mean?
Could you also add comment regarding the return type?
| @@ -476,79 +491,76 @@ where | |||
| async fn broadcast_and_execute<'a, V, F: 'a>( | |||
| &'a mut self, | |||
There was a problem hiding this comment.
Update function doc comment
fastpay_core/src/client.rs
Outdated
| @@ -718,65 +687,60 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Execute (or retry) a transfer order. Update local balance. | |||
| async fn execute_transfer( | |||
| /// Execute (or retry) a order. Update local balance. | |||
There was a problem hiding this comment.
"local balance" seems out-of-dated.
fastpay_core/src/client.rs
Outdated
| Ok((new_certificate, response.signed_effects.unwrap().effects)) | ||
| } | ||
|
|
||
| /// Execute (or retry) a order. Update local balance. |
lxfind
approved these changes
Jan 27, 2022
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broadcast_and_executeto handle multiple inputsexecute_transfertoexecute_transactionexecute_transactionto work withobject_transfer,move_call, andpublish