[verifier] Add module builder for easier testing #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
reviewed
Dec 29, 2021
| SignatureIndex((self.module.signatures.len() - 1) as u16) | ||
| } | ||
|
|
||
| fn add_address(&mut self, address: AccountAddress) -> AddressIdentifierIndex { |
There was a problem hiding this comment.
There is a similar function here--probably not worth unifying because this one is for testing + they do slightly different things, but wanted to point it out in case more unification is desired in the future.
sblackshear
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that has been holding me back from adding more verifier tests is the difficulty of constructing test modules. Trying to remember and get all the handles right was very confusing, and the code wasn't very readable. It will be very difficult to maintain as well.
Before it's too late, add a module builder that helps build modules for testing.
Note that due to a bug in Rust, we have to do
pub usein every test when importing the common library.