Replace Gas with Sui throughout end-to-end tutorial

[Clay-Mysten]

Replace Gas with Sui throughout end-to-end tutorial

[awelc]

This may require a wider consultation on how we want to phrase these in the docs. I am tagging @sblackshear and @adeabiodun on this one.

[awelc]

I would not do it this way. We use the term "Sui objects" quite pervasively to mean any object in Sui. Calling gas objects "Sui objects" as well will create an enormous amount of confusion.

I'd suggest leaving "gas" in these general descriptions and talk about "SUI" only if it matters (e.g., if we refer to the actual code in SUI.move).

[Clay-Mysten]

Thanks, Adam. I'm not finding any instances of "gas" that need replacement given the Wallet commands and output retain the term.

Instead, I'm trying to disambiguate in the glossary and will likely abandon this PR:
#1134

Please advise. Thanks.

[awelc]

I think it's a good idea. I guess my tagging @mystenadmin and @adeabiodun on this PR did not have the desired effect, but I would still suggest asking them about their view on the gas naming strategy in the docs and conversations about Sui.

[sblackshear]

Agreed that we should use SUI to refer to the Sui token. Wherever we say "gas objects", we should instead say "SUI tokens" or "SUI coins".

[Clay-Mysten]

Agreed that we should use SUI to refer to the Sui token. Wherever we say "gas objects", we should instead say "SUI tokens" or "SUI coins".

Whoops. Sorry i missed this, Sam. I was afraid of introducing confusion my mixing and matching, after speaking with Adam.

Does it make sense to rename this as "Gather accounts and SUI tokens" given the remainder of that section and doc use "gas objects" or some variant? Should we use SUI tokens/coins more liberally throughout?

Thanks for your guidance!

[awelc]

To throw another potential wrench into this (sorry), I seem to remember @gdanezis saying something along the lines of keeping the notion of gas a a form of computation payment (presumably as it is well understood in the industry) and saying that SUI tokens are used for gas payments.

We should really think this through and decide once and for all how to use both terms before we make any sweeping changes to the docs. Ideally we'd have a doc that summarizes guidance in this department so that there is no doubt in the future on how to use these terms.

[awelc]

These commands have not been updated for sure. Nor should they necessarily, I think (please see my other comment).

More generally, wallet outputs have not been updated to the new terminology (again, I don't think it's needed in may, possibly all, cases).

[gdanezis]

I agree. SUI will be our token, so we need to be careful how we message it. And also not to confuse people between the test tokens being used in test nets / dev nets and what will actually have value. Lets talk to our product people about how to do this best.

[Clay-Mysten]

Unless there are objections, I will close this PR.

[Clay-Mysten]

Adding George for review. The Marketing team is already included. Let's suss this out.

[econmysten]

i think we should follow existing conventions and
i) refer to gas as gas,
ii) refer to the unit cost of gas in our native currency SUI as the gas price,
iii) refer the product of gas * gas_price as the transaction fee

[Clay-Mysten]

i think we should follow existing conventions and i) refer to gas as gas, ii) refer to the unit cost of gas in our native currency SUI as the gas price, iii) refer the product of gas * gas_price as the transaction fee

The thing is, we don't mention price one time in:
https://docs.sui.io/explore/tutorials

We do refer to gas value repeatedly though. Ex. "Some gas was charged: the initial gas value was 10000, now it's 92939"

We could make that, "Some SUI was charged: the initial gas value was 100000, now it's 92939 with a transaction fee of 7061."

If we do that, we should introduce SUI at the first gas reference too.

Also, note I added your definitions above to the glossary, but that change still needs approval:
#1134

Further, if you see other references to gas on that page that should instead be SUI, I'd appreciate your help identifying them.

[econmysten]

We have a problem here:

1. The tutorial indeed does not measure the gas price and simply assumes that the user pays for gas directly using some gas token (which is presumably SUI). The tutorial does not describe what's going on under the hood and, indeed, this tutorial is consistent with a world where gas is directly invoiced in SUI. Which is not how Sui or other blockchains work.
2. Anyone familiar with gas will expect the transaction fee = gas_units * gas_price. Which is different from 1).
   So the problem we have is that the tutorial is at best imprecise regarding how Sui works or at worst wrong. This is OK because it's a tutorial of an early design of Sui.
   Ultimately, we will have a gas_price and the dev portal will reflect that. I see no reason in delaying this. At most, I'd add a footnote to the tutorial saying that "This tutorial models gas fees under a simplified schema. In practice, the Sui network will charge for gas using its native currency SUI. This transaction fee equals the computational effort of executing operations on the Sui network (i.e. gas units) times the price of gas in the SUI currency (i.e. the gas price)."

[Clay-Mysten]

We have a problem here:

1. The tutorial indeed does not measure the gas price and simply assumes that the user pays for gas directly using some gas token (which is presumably SUI). The tutorial does not describe what's going on under the hood and, indeed, this tutorial is consistent with a world where gas is directly invoiced in SUI. Which is not how Sui or other blockchains work.
2. Anyone familiar with gas will expect the transaction fee = gas_units * gas_price. Which is different from 1).
   So the problem we have is that the tutorial is at best imprecise regarding how Sui works or at worst wrong. This is OK because it's a tutorial of an early design of Sui.
   Ultimately, we will have a gas_price and the dev portal will reflect that. I see no reason in delaying this. At most, I'd add a footnote to the tutorial saying that "This tutorial models gas fees under a simplified schema. In practice, the Sui network will charge for gas using its native currency SUI. This transaction fee equals the computational effort of executing operations on the Sui network (i.e. gas units) times the price of gas in the SUI currency (i.e. the gas price)."

I've added this note to the Set up section of the tutorial, before the first gas reference, in:
#1170

This does beg the question how we use gas elsewhere and whether those uses are correct, for example in the Move and Wallet docs but truly across the site:
https://docs.sui.io/build/move
https://docs.sui.io/build/wallet

Keeping this PR open for deliberation in lieu of that plan Adam has requested.

[Clay-Mysten]

NO NOT MERGE

The original issue here has been addressed in:
#1170

Leaving this open temporarily to see if other changes are required. See the hearty discussion here.

[Clay-Mysten]

Now closing this out as a no-op