Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixes to the Wallet tutorial related to GAS->SUI renaming #1135

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

awelc
Copy link
Contributor

@awelc awelc commented Mar 30, 2022

In addition to renaming-related changes, I also matched current output of publish command with what's in the actual implementation, and also added a link to SuiJSON to explain unusual formatting of Move call arguments.

@awelc awelc requested a review from Clay-Mysten as a code owner March 30, 2022 01:23
Another object created as a result of package publishing is a
user-defined object (of type `Forge`) crated inside initializer
function of the (only) module included in the published package - see
the parrt of Move developer documentation concerning [module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part

Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo. Otherwise, LGTM. Thanks, Adam!

@awelc awelc merged commit fa90884 into main Mar 30, 2022
@awelc awelc deleted the aw/docs-sui-rename-fix-wallet branch March 30, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants