Update wallet.md #1174
Update wallet.md #1174
Conversation
Committing first round of edits to Wallet Making many, many small enhancements for clarity
Add back dollar signs, split output from commands
Reinstate original genesis customization verbiage
Move client_db TODO up for visibility as we call for that file later
doc/src/build/wallet.md
Outdated
| ``` | ||
|
|
||
| All of this is contained in configuration and keystore files, as well | ||
| as an `authorities_db` database file. | ||
| TODO: Why do I no longer see a `client_db` file created, only `authorities_db` now? |
There was a problem hiding this comment.
I don't have an answer for this but wanted to make sure we do not land this change with a TODO in it (@patrickkuo ?)
There was a problem hiding this comment.
client_db folder is created by the wallet when it's first started
There was a problem hiding this comment.
Do you mean when we run this?
wallet --no-shell new-address
Because simply starting wallet doesn't do it.
There was a problem hiding this comment.
Also, that command assumes the files live in my home dir:
Error: Cannot open wallet config file at "/Users/claymurphy/.sui/sui_config/wallet.conf"
So I have to run:
claymurphy@Clays-MacBook-Pro tmp % wallet --config wallet.conf --no-shell new-address
@awelc how is this easier than having someone manually mkdir the directory of their choosing for all of this?
There was a problem hiding this comment.
Ah, wallet --config wallet.conf --no-shell new-address run in tmp/ where I have the config files results in a new tmp/client_db path. See:
claymurphy@Clays-MacBook-Pro tmp % ls -lah
total 24
drwxr-xr-x 7 claymurphy staff 224B Apr 4 08:31 .
drwxr-x---+ 29 claymurphy staff 928B Mar 31 14:43 ..
drwxr-xr-x 6 claymurphy staff 192B Mar 31 14:43 authorities_db
-rw-r--r-- 1 claymurphy staff 1.2K Mar 31 14:43 network.conf
drwxr-xr-x 3 claymurphy staff 96B Apr 4 08:31 tmp
-rw-r--r-- 1 claymurphy staff 1.3K Apr 4 08:34 wallet.conf
-rw-r--r-- 1 claymurphy staff 472B Mar 31 14:43 wallet.key
claymurphy@Clays-MacBook-Pro tmp % ls -lah tmp
total 0
drwxr-xr-x 3 claymurphy staff 96B Apr 4 08:31 .
drwxr-xr-x 7 claymurphy staff 224B Apr 4 08:31 ..
drwxr-xr-x 13 claymurphy staff 416B Apr 4 08:34 client_db
claymurphy@Clays-MacBook-Pro tmp % cd tmp
claymurphy@Clays-MacBook-Pro tmp % ls
client_db
claymurphy@Clays-MacBook-Pro tmp % pwd
/Users/claymurphy/tmp/tmp
Is this intended? Do we specify the wallet CLI must be run from a particular directory? I seem to recall that in earlier versions but not in the current version.
There was a problem hiding this comment.
I was not aware of this. I would suggest having client_db's default location to be ~/.sui/sui_config/ as well exactly for the the reason @Clay-Mysten mentions - we don't want to force a specific directory creation, but we may want to allow it. We could also make the directory for wallet to be ~/.sui/wallet_config and have both wallet.conf, wallet.key and client_db to go there by default. @patrickkuo?
There was a problem hiding this comment.
the wallet will write the client_db to the same dir as the wallet.conf , it will cause problem if user starts 2 instances of wallet connecting to 2 different network if we hardcode the client_db to ~/.sui/wallet_config
There was a problem hiding this comment.
@patrickkuo But in my case, I ran the wallet new-address command in my tmp' directory where wallet.conflives, specifying it with the--config` flag, only to have a path of:
tmp/tmp/client_db
That doesn't seem right.
There was a problem hiding this comment.
See my input and output above.
doc/src/build/wallet.md
Outdated
| claymurphy@Clays-MacBook-Pro tmp % ps -ef | grep -i sui | ||
| 501 442 1 0 12:02PM ?? 0:00.22 /System/Library/CoreServices/CoreServicesUIAgent.app/Contents/MacOS/CoreServicesUIAgent | ||
| 501 623 1 0 12:03PM ?? 0:01.10 /System/Library/PrivateFrameworks/AppleMediaServicesUI.framework/amsengagementd | ||
| 501 1433 1 0 1:01PM ?? 0:00.21 /System/Library/PrivateFrameworks/PaperKit.framework/Contents/LinkedNotesUIService.app/Contents/MacOS/LinkedNotesUIService |
There was a problem hiding this comment.
I am fishing here - REST API server running locally?
There was a problem hiding this comment.
you can check which command is using the port using lsof -i tcp:10000
There was a problem hiding this comment.
Good to know. I blew everything away and started over to get this working. Can we generate a more useful error message here?
Co-authored-by: Adam Welc <adam@mystenlabs.com>
Co-authored-by: Adam Welc <adam@mystenlabs.com>
Co-authored-by: Adam Welc <adam@mystenlabs.com>
Remove example directory per Adam
Remove TODOs, note `client_db` creation.
Committing first round of edits to Wallet
Making many, many small enhancements for clarity