[Gas Metering] More accurate object size calculation #1249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need object size to properly calculate both of the computation cost and storage cost.
We could try to serialize the object to bytes and look at the serialized size, but that's too costly and we don't need to be that accurate. We should focus on what brings most of the size and that should be sufficient.
This PR looks at the size of all metadata and vectors and strings in the objects.