-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ts-sdk] Define the Signer interface #1308
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
+ Coverage 81.72% 81.75% +0.02%
==========================================
Files 100 100
Lines 20966 20972 +6
==========================================
+ Hits 17134 17145 +11
+ Misses 3832 3827 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, few minor questions but could be merged as-is
As mentioned below, this PR defines the "Signer" interface for the Typescript SDK. The subsequent PRs will add missing implementations for:
Use cases
Some example scenarios where this SDK might be used:
API Design
The API design takes inspiration from Ethers.js and separates the API into two different parts:
In addition, we also expose a
TxDataSerializer
API that allows the caller to construct a BCS encoded transaction data. Application developers should not need to use this directly.DevNet API
Future changes
execute_move_call
will be deprecated in favor of ABI generated contract APIUsage of the SDK
Testing
sui.js
sdksui.js
to the React App