Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename object owner types #1438

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Rename object owner types #1438

merged 1 commit into from
Apr 19, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 19, 2022

Per discussion in #1408,
we now categorize objects into two categories: immutable and mutable. Mutable objects are further divided to two categories: owned and shared.
We will stick to this set of terminology across the board.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1438 (d37b0ae) into main (72dbf0b) will decrease coverage by 0.10%.
The diff coverage is 87.93%.

@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
- Coverage   82.45%   82.35%   -0.11%     
==========================================
  Files         103      103              
  Lines       21069    21070       +1     
==========================================
- Hits        17373    17352      -21     
- Misses       3696     3718      +22     
Impacted Files Coverage Δ
sui_programmability/framework/src/lib.rs 86.12% <ø> (ø)
sui_types/src/error.rs 50.00% <ø> (ø)
sui_types/src/messages.rs 89.36% <50.00%> (ø)
sui_core/src/transaction_input_checker.rs 87.68% <80.00%> (ø)
sui_programmability/adapter/src/adapter.rs 89.35% <80.00%> (ø)
sui_core/src/authority/temporary_store.rs 83.52% <83.33%> (-0.79%) ⬇️
sui_types/src/object.rs 81.28% <89.47%> (-0.47%) ⬇️
sui_core/src/authority.rs 94.95% <100.00%> (ø)
sui_core/src/authority/authority_store.rs 90.92% <100.00%> (ø)
sui_core/src/unit_tests/authority_tests.rs 87.38% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72dbf0b...d37b0ae. Read the comment docs.

Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Xun!

@lxfind lxfind merged commit 03a4b00 into main Apr 19, 2022
@lxfind lxfind deleted the rename-shared branch April 19, 2022 18:00
@Clay-Mysten
Copy link
Contributor

Also let me know if we should summarize here:
https://docs.sui.io/learn/sui-glossary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants