[crypto] SuiAddress derivation via sha3 #1481
Conversation
kchalkias
force-pushed
the
kostas-sha3-everything
branch
2 times, most recently
from
5fc3869 to
f257c9b
Compare
kchalkias
force-pushed
the
kostas-sha3-everything
branch
from
f257c9b to
afb713a
Compare
There was a problem hiding this comment.
Since we need to keep the admin address in sync with the hashing function, why not add a test that checks it?
If we do not want to reveal the preimage of the admin address, instead of testing sha3(foo) == ADMIN_ADDRESS, we can have a useless #[cfg(test)] constant ADMIN_SENTINEL defined on the preceding line, do the test on that variable, and precede it by a comment saying "If you're updating this because a test broke, please update the admin address too".
|
I think that in the ed25519 we implicitly also use sha512? Worth checking? |
Good point, but this is explicit to the internal signature RFC specs (hidden from our repo), not a Sui protocol hash selection decision. |
kchalkias
force-pushed
the
kostas-sha3-everything
branch
from
da0535a to
c181c4c
Compare
|
@huitseeker back to you, per your recommendation, a slightly more generic test has been introduced that will help us spot any changes to the SuiAddress derivation algorithm in the future. |
| fn test_admin_address_consistency() { | ||
| use hex; | ||
| let (admin_address, _) = make_admin_account(); | ||
| assert_eq!(admin_address.to_vec(), hex::decode(ADMIN_SENTINEL).expect("Decoding failed"), | ||
| "If this test broke, then the algorithm for deriving addresses from public keys has \ | ||
| changed. Please compute the new admin address in hex format from `make_admin_account`\ | ||
| and update both the ADMIN_SENTINEL const above, but also the ADMIN address to \ | ||
| Hero.move with the new admin account hex value."); | ||
| } |
We currently mix sha2 (pubKey->address) and sha3 (objects/transaction) and this is an attempt to unify our hash-digest functionality into a single behavior and scheme.
This is very important for a) auditing purposes b) consistency c) less dependencies (-sha2)