Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to new Narwhal overview from validators description, edit surrounding text #1615

Merged
merged 2 commits into from
May 2, 2022

Conversation

Clay-Mysten
Copy link
Contributor

No description provided.

@@ -31,7 +31,7 @@ As with transactions, we note that the process of sharing a certificate with val

## The role of Narwhal and Tusk

Sui takes advantage of [Narwhal and Tusk: A DAG-based Mempool and Efficient BFT Consensus](https://arxiv.org/pdf/2105.11827.pdf). Narwhal/Tusk (N/T) are also being developed by [Mysten Labs](https://mystenlabs.com/) so that per the referenced white paper, “When full agreement is required we use a high-throughput DAG-based consensus, e.g. [9] to manage locks, while execution on different shared objects is parallelized.
Sui takes advantage of [Narwhal and Tusk: A DAG-based Mempool and Efficient BFT Consensus](consensus.md). Narwhal/Tusk (N/T) are also being developed by [Mysten Labs](https://mystenlabs.com/) so that when full agreement is required we use a high-throughput DAG-based consensus to manage locks while execution on different shared objects is parallelized.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full agreement -> Byzantine agreement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

developed by -> implemented by

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to mange locks -> to manage shared locks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmh parallelising the execution of different shared objects has little to do with consensus and the locks (this sentence could be confusion)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alberto,

Can you create a PR with your changes and have Francois review it? This is a link swap PR. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alberto,

Can you create a PR with your changes and have Francois review it? This is a link swap PR. :-)

I took care of all of these changes except for the last, which isn't actionable. I don't even know what sentence this refers too.

So I filed this new issue for you and Francois to review and edit the entire page as a team:
#1638

Thanks!

@huitseeker huitseeker added the Type: Documentation Improvements or additions to documentation label Apr 27, 2022
Make Alberto's changes
@Clay-Mysten Clay-Mysten changed the title Link to new Narwhal overview from validators description Link to new Narwhal overview from validators description, edit surrounding text Apr 27, 2022
@Clay-Mysten Clay-Mysten requested a review from asonnino April 27, 2022 23:38
@Clay-Mysten Clay-Mysten merged commit 1170dba into main May 2, 2022
@Clay-Mysten Clay-Mysten deleted the Clay-Mysten-patch-8 branch May 2, 2022 20:38
longbowlu pushed a commit that referenced this pull request May 12, 2022
…nding text (#1615)

* Link to new Narwhal overview from validators description

* Update validators.md

Make Alberto's changes
punwai pushed a commit that referenced this pull request Jul 27, 2022
…nding text (#1615)

* Link to new Narwhal overview from validators description

* Update validators.md

Make Alberto's changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants