Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tutorial Chapter 3 regarding testing immutable objects #1667

Merged
merged 2 commits into from
May 1, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 29, 2022

#1558 changed the API to interact with immutable objects in unit tests.
This PR updates the tutorial to reflect the changes.

@lxfind lxfind requested review from awelc, tnowacki and damirka April 29, 2022 04:11
@lxfind lxfind requested a review from Clay-Mysten as a code owner April 29, 2022 04:11
Make direct edits to  testing immutable objects addition
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Xun. I made some direct edits you are welcome to revert. Thanks!

@lxfind
Copy link
Contributor Author

lxfind commented Apr 29, 2022

Thanks Clay! Looks good!

@lxfind lxfind merged commit 2e824e5 into main May 1, 2022
@lxfind lxfind deleted the tutorial-take-immutable branch May 1, 2022 16:59
longbowlu pushed a commit that referenced this pull request May 12, 2022
* Update Tutorial Chapter 3 regarding testing immutable objects

* Update ch3-immutable-objects.md

Make direct edits to  testing immutable objects addition

Co-authored-by: Clay-Mysten <100217682+Clay-Mysten@users.noreply.github.com>
punwai pushed a commit that referenced this pull request Jul 27, 2022
* Update Tutorial Chapter 3 regarding testing immutable objects

* Update ch3-immutable-objects.md

Make direct edits to  testing immutable objects addition

Co-authored-by: Clay-Mysten <100217682+Clay-Mysten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants