Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript SDK] Fix data types for transactions #1681

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Apr 29, 2022

There was some data type mismatch in the SDK with the RPC server, causing @Jibz1 to see some error thrown by SDK on the frontend for txn digest edEqyhYjoTVzN+Lky9SqXGKL4GWSdPZFSnYWk+fPyqg=.

Added unit tests and also test against the problematic txn digest provided by @Jibz1

CleanShot 2022-04-29 at 15 54 33

@666lcz 666lcz requested review from Jibz1, apburnie and stella3d April 29, 2022 23:43
@666lcz 666lcz enabled auto-merge (squash) April 29, 2022 23:44
@666lcz 666lcz merged commit f38b35b into main Apr 30, 2022
@666lcz 666lcz deleted the chris/sdk-fix-transactions branch April 30, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants