Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] object_id must already exist in accounts #17

Merged
merged 2 commits into from
Dec 2, 2021
Merged

[NFC] object_id must already exist in accounts #17

merged 2 commits into from
Dec 2, 2021

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Dec 2, 2021

In the previous lines it was already verified that the object ID must exist in the accounts. No need to use or_insert_with().

Copy link
Collaborator

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Address feedback, use "expect" instead of unwrap
@lxfind lxfind merged commit 5171d5d into MystenLabs:main Dec 2, 2021
mwtian pushed a commit that referenced this pull request Sep 12, 2022
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
brson pushed a commit to brson/sui that referenced this pull request Apr 30, 2024
040824-fixing-vector-tests-size_limit_ok-1: iini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants