Explore tx 3 #1722
Merged
Explore tx 3 #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
approved these changes
May 2, 2022
| }; | ||
|
|
||
| const getGasFeesAndStatus = (txStatusData: ExecutionStatus) => { | ||
| const istxSucces = Object.keys(txStatusData)[0].toLowerCase(); |
There was a problem hiding this comment.
Calling a string istxSuccess is pretty confusing. Could you define
export type ExecutionStatusType = 'Success' | 'Failure';
in
as well as a SDK function like the following:
export function getExecutionStatusType(s: ExecutionStatus): ExecutionStatusType {
return Object.keys(txStatusData)[0] as ExecutionStatusType;
}
| txError: '', | ||
| }; | ||
|
|
||
| const getGasFeesAndStatus = (txStatusData: ExecutionStatus) => { |
There was a problem hiding this comment.
This duplicates line 33 in explorer/client/src/components/transaction-card/RecentTxCard.tsx . Can you define these functions here instead since it's pretty common?
There was a problem hiding this comment.
I am working on moving it to the helper functions
| return { | ||
| istxSucces, | ||
| txGas, | ||
| // txErr: txStatusData.Failure || '', |
| return { | ||
| istxSucces, | ||
| txGas, | ||
| // txErr: txStatusData.Failure || '', |
| @@ -51,10 +71,17 @@ const getRecentTransactions = async (txNum: number) => { | |||
| res.data | |||
| )?.recipient; | |||
|
|
|||
| // TODO use ExecutionStatus and add a method on sui.js to get the gas data | |||
There was a problem hiding this comment.
can we do this in this PR? Let's do a huddle if you need help
|
Gas payment added, |
666lcz
approved these changes
May 3, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
Co-authored-by: Chris Li <666lcz@gmail.com>
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Co-authored-by: Chris Li <666lcz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added transaction status on recent transactions
Gas use is now active
Switched to getTransactionWithEffects
Tx detail page shows the transaction status and failed status message.