[RPC gateway] - Add test for each of the RPC endpoint #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 3, 2022
patrickkuo
requested review from
bmwill,
666lcz,
awelc,
lxfind,
oxade and
sblackshear
huitseeker
approved these changes
May 4, 2022
| let result: ObjectResponse = http_client.get_owned_objects(*address).await?; | ||
| let result = result | ||
| .objects | ||
| .into_iter() |
There was a problem hiding this comment.
Nit, this could probably be an iter here and below.
There was a problem hiding this comment.
oh... to_object_ref ' s signature is pub fn to_object_ref(self) -> Result<ObjectRef, anyhow::Error>, so this need to be into_iter
patrickkuo
force-pushed
the
pat/rpc_server_test
branch
from
1144fe0 to
64d3047
Compare
patrickkuo
force-pushed
the
pat/rpc_server_test
branch
from
64d3047 to
0af011c
Compare
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.