[wallet bugfix] - Wallet interactive mode does not accept whitespaces in arguments #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
May 4, 2022
| @@ -216,3 +217,19 @@ fn test_completer_with_cache() { | |||
| .collect::<Vec<_>>(); | |||
| assert_eq!(vec!["--gas"], candidates); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_split_line() { | |||
There was a problem hiding this comment.
I think an easy test would be to run this through the BLNS.
There was a problem hiding this comment.
Nice, I will try to add that after DevNet
arun-koshy
approved these changes
May 4, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
… in arguments (#1795) * changed transfer -> transfer-coin * add unit test
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
… in arguments (#1795) * changed transfer -> transfer-coin * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
shell_words::split(line)to split cmd line input for the interactive shell instead of splitting by whitespace,shell_words::splitperform the same split as unix split (remove quotes etc), this makes the wallet command behave the same in interactive or non-interactive mode.