Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Listen on 0.0.0.0 #2090

Merged
merged 1 commit into from
May 20, 2022

Conversation

velvia
Copy link
Contributor

@velvia velvia commented May 20, 2022

Really simple one line fixes. The old value was 127.0.0.1 which prevents metrics from listening on external connections.

I could expand this to use ValidatorConfig for validators if @bmwill could show me how to convert multiaddr to SocketAddr, but I couldn't' find an easy way, and we're just trying to get this working quickly for observability.

@velvia velvia requested review from bmwill and tharbert May 20, 2022 04:50
@bmwill
Copy link
Contributor

bmwill commented May 20, 2022

@velvia Yeah i did add a, currently unused, metrics address to the ValidatorConfig. We can add the ability to convert the Multiaddr to a socket addr and then use it in a future PR.

@velvia
Copy link
Contributor Author

velvia commented May 20, 2022

Thanks @bmwill I just didn't know how to convert to SocketAddr, I didn't find anything tin the MultiAddr docs.rs... a third party crate seemed to do it but didn't think it made sense to bring in another crate just to do conversion, thought you might know a better way.

Or we can just go back to host and port config. :-p

@velvia velvia merged commit 703d692 into MystenLabs:main May 20, 2022
@velvia velvia deleted the ec/fix-prom-listening-addr branch May 20, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants