Add gas and created to OrderEffects #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
patrickkuo,
sblackshear,
gdanezis and
oxade
sblackshear
approved these changes
Jan 22, 2022
|
This makes things simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing
OrderEffects, we only have a list of mutated objects, which contains anything that was mutated, created, and also include the gas object which is always mutated.This makes it very inconvenient to know which is which.
This PR adds two extra elements to
OrderEffects,gas_objectandcreated. They will not be in themutatedlist. This makes it a lot easier to tell what happened to the objects.This closes #244.