Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastx authority docs] Added docs to the fields in authority state #299

Merged
merged 4 commits into from
Jan 29, 2022
Merged

[fastx authority docs] Added docs to the fields in authority state #299

merged 4 commits into from
Jan 29, 2022

Conversation

gdanezis
Copy link
Collaborator

Added docs to all fields within authority state that that we all know what they are storing and to some extent why.

@gdanezis gdanezis requested a review from lxfind January 28, 2022 23:17
@gdanezis gdanezis self-assigned this Jan 28, 2022
@gdanezis gdanezis added the Type: Documentation Improvements or additions to documentation label Jan 28, 2022
@gdanezis gdanezis added this to the Milestone 3 milestone Jan 28, 2022
@gdanezis gdanezis mentioned this pull request Jan 28, 2022
Closed
lxfind
lxfind approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@lxfind lxfind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

huitseeker
huitseeker approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@gdanezis gdanezis merged commit 8d5c75e into main Jan 29, 2022
@gdanezis gdanezis deleted the authority-state-document branch January 29, 2022 00:23
mwtian pushed a commit that referenced this pull request Sep 12, 2022
@Clay-Mysten @huitseeker
Review and edit Narwhal Docker README (#299)
f20c2b3 
* Update README.md

* Update README.md

* Update Docker/README.md

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>

* Update Docker/README.md

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
@Clay-Mysten @huitseeker
Review and edit Narwhal Docker README (MystenLabs#299)
c141393 
* Update README.md

* Update README.md

* Update Docker/README.md

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>

* Update Docker/README.md

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>

Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@lxfind lxfind lxfind approved these changes

Assignees

@gdanezis gdanezis

Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdanezis @huitseeker @lxfind