[Client Refactoring 6] Split download_certificates #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
patrickkuo,
sblackshear,
gdanezis and
oxade
lxfind
force-pushed
the
download_owned_objects
branch
from
55d585a to
2eef81a
Compare
lxfind
force-pushed
the
split_download_certificates
branch
from
233d959 to
b5563a3
Compare
oxade
approved these changes
Feb 4, 2022
huitseeker
approved these changes
Feb 5, 2022
Comment on lines
+853
to
+865
| ( | ||
| (object_id, next_sequence_number), | ||
| self.certificates(&object_id) | ||
| .flat_map(|cert| cert.order.input_objects()) | ||
| .filter_map(|object_kind| { | ||
| if object_kind.object_id() == object_id { | ||
| Some(object_kind.version()) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect::<HashSet<_>>(), | ||
| ) |
There was a problem hiding this comment.
Nit: this seems marginally more readable
let versions = self.certificates(&object_id) ..;
((object_id, next_sequence_number), versions)* [Client Refactoring 7] Lock/unlock order upfront * [Client Refactoring 8] Add AuthorityAggregator (#364) * [Client Refactoring] Add AuthorityAggregator * [Client Refactoring 9] Make download_objects_not_in_db fast again (#368) * [Client Refactoring 9] Make download_objects_not_in_db fast again * [Clienet Refactoring 10] Properly lock orde forr transfer_to_fastx_unsafe_unconfirmed (#369)
* [Client Refactoring 7] Lock/unlock order upfront * [Client Refactoring 8] Add AuthorityAggregator (#364) * [Client Refactoring] Add AuthorityAggregator * [Client Refactoring 9] Make download_objects_not_in_db fast again (#368) * [Client Refactoring 9] Make download_objects_not_in_db fast again * [Clienet Refactoring 10] Properly lock orde forr transfer_to_fastx_unsafe_unconfirmed (#369)
…enLabs/fastnft into split_download_certificates
lxfind
force-pushed
the
split_download_certificates
branch
from
db05ab4 to
b1e2410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
download_certificatesinto stateful and stateless parts, preparing for the final refactoring.