Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert failure to anyhow #42

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix: convert failure to anyhow #42

merged 1 commit into from
Dec 9, 2021
+75 −76

Conversation

huitseeker
Copy link
Contributor

Fixes #41

@huitseeker huitseeker merged commit 20b313d into MystenLabs:main Dec 9, 2021
amnn added a commit that referenced this pull request Apr 4, 2024
@amnn
[Release Notes] Script to extract release notes in the new format (#1…
ddd13e8 
…7043)

## Description

Script extracts release notes in the new format where a single PR can
contain different breaking changes for each functional area

## Test Plan

Tested manually against a set of local commits.

Example output from `generate` command:

```
## Protocol
Sui Protocol Version in this release: 43

#42:
Bumped protocol version to 42

#9001:
You get a release note

## Nodes (Validators and Full nodes)

#44:


## Indexer

#9001:
You get a release note

## JSON-RPC

#42:
Made some sweeping changes, to:
  - Foo
  - Bar

## CLI

#9001:
Everybody gets release notes
```

Example output from `check` command (if there are issues):

```
Found issues with release notes in amnn/test-release-notes^:
 - 'Protocol' has a release note but is not checked: An important message, can't miss!
 - 'Nodes (Validators and Full nodes)' is checked but has no release note.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblackshear sblackshear sblackshear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devex] use anyhow crate for Result instead of failure
2 participants
@huitseeker @sblackshear