OrderEffects.mutated should include gas_object #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
patrickkuo,
sblackshear,
gdanezis and
oxade
lxfind
force-pushed
the
mutated-include-gas
branch
from
5d89cfb to
baa09f3
Compare
lxfind
force-pushed
the
mutated-include-gas
branch
from
baa09f3 to
de9b513
Compare
lxfind
force-pushed
the
mutated-include-gas
branch
from
de9b513 to
9729eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's likely more clear to have mutated include gas_object.
This PR changes to that, and introduce an extra function that allows for getting mutated objects excluding gas for convenience.