explorer-client: improve linting rules #506
Conversation
explorer/client/.eslintrc.js
Outdated
| @@ -9,10 +10,19 @@ module.exports = { | |||
| ['internal', 'parent', 'sibling', 'index'], | |||
| 'type', | |||
| ], | |||
| pathGroups: [ | |||
| { | |||
| pattern: '{.,..}/**/*.?(s)css', | |||
There was a problem hiding this comment.
We do not need scss handling. As in other PR complexity should be avoided unless it is needed.
There was a problem hiding this comment.
Let's leave it there since it's there already, even if we remove scss or add them later, there will be no need to visit this again
There was a problem hiding this comment.
yes, let's remove this. Anything unused should always be removed
If we agree that the rules are correct, I don't see any reason adding code that might not comply and then fixing it. |
|
Team discussions suggest that the top priority is the demo at the end of March. Being pessimistic, we could potentially present a demo with a mock data backend. We cannot present a demo where the UI is incomplete. Hence, for now, the focus needs to be on website functionality. After the tight deadline has passed, we can then shift attention to refactoring and optimizations. This PR is part of this process. After the demo deadline, it would also be of value to have a team meeting to set refactoring priorities. That meeting is likely to feed into this PR and to shape what rules we use going forwards. |
pchrysochoidis
force-pushed
the
pc-480-improve-linting
branch
from
b89d884 to
5916221
Compare
pchrysochoidis
force-pushed
the
pc-480-improve-linting
branch
from
5916221 to
2522d9f
Compare
explorer/client/.eslintrc.js
Outdated
| @@ -9,10 +10,19 @@ module.exports = { | |||
| ['internal', 'parent', 'sibling', 'index'], | |||
| 'type', | |||
| ], | |||
| pathGroups: [ | |||
| { | |||
| pattern: '{.,..}/**/*.?(s)css', | |||
There was a problem hiding this comment.
yes, let's remove this. Anything unused should always be removed
|
This looks good, but i agree we should remove SCSS handling. |
* no binding for jsx attrs * no duplicate imports * group scss/css imports together after type imports
* also rename index.scss to index.css (leftover from scss removing)
pchrysochoidis
force-pushed
the
pc-480-improve-linting
branch
from
2522d9f to
d86d1af
Compare
resolves #480