Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added macro for polling boolean expression with timeout in unit test #514

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

patrickkuo
Copy link
Contributor

This macro simplifies the logic for retrying boolean expressions, e.g. checking server availability in test

@patrickkuo patrickkuo self-assigned this Feb 22, 2022
@patrickkuo patrickkuo mentioned this pull request Feb 22, 2022
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting use of macro to re eval a symbolic expression.

Copy link
Contributor

@oxade oxade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this quickly

@patrickkuo patrickkuo merged commit 8585796 into main Feb 22, 2022
@patrickkuo patrickkuo deleted the pat/retry_assert branch February 22, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants