Improve Move call type checking part1 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
approved these changes
Feb 23, 2022
| @@ -273,7 +273,7 @@ module Examples::Hero { | |||
| } | |||
|
|
|||
| // --- Testing functions --- | |||
| fun assert_hero_strength(hero: &Hero, strength: u64, _: &mut TxContext) { | |||
| public fun assert_hero_strength(hero: &Hero, strength: u64, _: &mut TxContext) { | |||
There was a problem hiding this comment.
Totally fine to make all of these public--thanks!
lxfind
reviewed
Feb 23, 2022
lxfind
reviewed
Feb 23, 2022
lxfind
reviewed
Feb 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in having a unified way to check move call args both in the client and authorities.
Here we separate out the logic for type checking so that other modules can use it.
We also make
MovePackagea concrete type (instead of just a BTreeMap alias) which we will add more functionality to the checker in future.The next step is to flesh out the checks, and use this check module in the client for arg linting.
Note:
move_call_type_check.rsname is not the best. Open to suggestions.MovePackage