Unify the size of SuiAddress and ObjectID (also move AccountAddress) #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
awelc,
sblackshear,
gdanezis and
666lcz
huitseeker
approved these changes
Feb 23, 2022
|
Hugely in favor of removing |
oxade
reviewed
Feb 23, 2022
| @@ -582,7 +582,7 @@ async fn test_handle_move_transaction() { | |||
|
|
|||
| // Check that gas is properly deducted. | |||
| // If the number changes, we want to verify that the change is intended. | |||
| let gas_cost = 62; | |||
| let gas_cost = 53; | |||
There was a problem hiding this comment.
where do we get this number from?
There was a problem hiding this comment.
I manually looked at the gas used.
|
Love that SuiAddress is no longer Vec! |
…ytes This changes from Addresses on 32 bytes.
There is no situation where the `TryFrom<&[u8]>` isn't more flexible and preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectIDand MoveAccountAddresshave been 20 bytes, whileSuiAddresshas been 32 bytes.This difference in size made it impossible to use the native
addressMove type to representSuiAddress. We have been using a custom definedAddresswrapper of raw bytes to representSuiAddress.Now that we are aligned that
SuiAddressand MoveAccountAddresscan be the same length, this PR aligns them and removes theAddresstype from Sui framework. (See #519)Specifically, this PR does the following:
Address.move, which removes bothAddresstype andSignertype from the framework. All uses are replaced with the native typeaddressandsigner.AccountAddresstype.new_signer_from_addressto create a signer from an address, for testing purpose only.A few TODOs left:
IDBytesfrom Sui Move framework, as it's now just a wrapper ofaddress.ObjectID,AccountAddress,SuiAddress. The conversion logic is getting a bit messy. There is probably some cleanup we could do there.