Refactor ClientState API #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
patrickkuo,
sblackshear,
gdanezis,
oxade and
arun-koshy
lxfind
force-pushed
the
client-api-refactor
branch
from
2bf48ab to
55c96b1
Compare
lxfind
force-pushed
the
client-api-refactor
branch
from
55c96b1 to
12f13ed
Compare
4 tasks
patrickkuo
approved these changes
Mar 1, 2022
| @@ -325,21 +325,25 @@ async fn sui_start( | |||
|
|
|||
| // Sync all accounts. | |||
| for address in addresses.iter() { | |||
| let client_state = wallet_context | |||
| .get_or_create_client_state(address) | |||
| wallet_context | |||
There was a problem hiding this comment.
rest server should create its own account manager instead of using the wallet context, we can fix this after key pair removal, rest server will no longer need to handle keys after that.
Comment on lines
+525
to
+533
| wallet_context | ||
| .create_account_state(address) | ||
| .map_err(|error| { | ||
| custom_http_error( | ||
| StatusCode::FAILED_DEPENDENCY, | ||
| format!("Could not get or create client state: {error}"), | ||
| )); | ||
| } | ||
| }; | ||
| let object_refs = client_state.object_refs(); | ||
| ) | ||
| })?; | ||
| let object_refs = wallet_context.address_manager.get_owned_objects(*address); |
There was a problem hiding this comment.
we shouldn't need to call create_account_state explicitly, the account manager should handle it internally, however I guess it is not doable at the moment because of the key pair, will need to refactor this after #594
lxfind
force-pushed
the
client-api-refactor
branch
from
12f13ed to
13c69dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #577.
The current Client APIs are all implemented on ClientState which is per-account. This is problematic.
We want the APIs to be implemented on ClientAddressManager.
This PR moves all APIs over, and fixes all uses, tests and etc.