Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[authority] Ensure Idempotent Reply #679

Merged
merged 21 commits into from
Mar 8, 2022
Merged

[authority] Ensure Idempotent Reply #679

merged 21 commits into from
Mar 8, 2022

Conversation

asonnino
Copy link
Contributor

@asonnino asonnino commented Mar 7, 2022 •
edited
Loading

What is done:

  • Ensure a idempotent reply when a client submits a certificate containing a shared object.

@asonnino asonnino changed the title Idempotent reply [authority] Ensure Idempotent Reply Mar 7, 2022
@asonnino asonnino self-assigned this Mar 7, 2022
@asonnino asonnino added the Type: Enhancement New feature or request label Mar 7, 2022
huitseeker
huitseeker previously requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't allow merge commits on mains, and this seems to have embarked a few of them.

Here's one way to solve this for you once and for all:
https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull

This configuration is a standard-issue best practice by now.

How to solve this for this PR: rebase on main, possibly interactively (-i) and keeping only relevant commits.

sui_types/src/object.rs Outdated
@@ -34,7 +34,7 @@ pub const OBJECT_START_VERSION: SequenceNumber = SequenceNumber::from_u64(1);
pub struct MoveObject {
pub type_: StructTag,
#[serde_as(as = "Bytes")]
contents: Vec<u8>,
pub contents: Vec<u8>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this one?

sui_core/src/authority.rs Outdated
Comment on lines 837 to 840
#[cfg(test)]
pub fn database(&self) -> &Arc<AuthorityStore> {
&self._database
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems unrelated.

@asonnino
Copy link
Contributor Author

asonnino commented Mar 7, 2022

We don't allow merge commits on mains, and this seems to have embarked a few of them.

Here's one way to solve this for you once and for all: https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull

This configuration is a standard-issue best practice by now.

How to solve this for this PR: rebase on main, possibly interactively (-i) and keeping only relevant commits.

wow something strange happened, let me fix all of that (and make sure there are no other surprises)

@asonnino asonnino requested a review from huitseeker March 8, 2022 10:21
gdanezis
gdanezis approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this check needs to be done for both indeed

@asonnino asonnino merged commit e12cd25 into MystenLabs:main Mar 8, 2022
@asonnino asonnino deleted the idempotent-reply branch March 8, 2022 11:41
mwtian pushed a commit that referenced this pull request Sep 12, 2022
@dependabot
chore(deps): bump serde_json from 1.0.82 to 1.0.83 (#679)
d3cb205
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
@dependabot
chore(deps): bump serde_json from 1.0.82 to 1.0.83 (MystenLabs#679)
df90d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdanezis gdanezis gdanezis approved these changes

@huitseeker huitseeker Awaiting requested review from huitseeker

Assignees

@asonnino asonnino

Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asonnino @huitseeker @gdanezis