Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] reorganize examples directory #712

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

sblackshear
Copy link
Collaborator

@sblackshear sblackshear commented Mar 9, 2022

  • Splitting the examples directory into several smaller directories with clearly defined themes
  • Added a README to each dir with brief descriptions of the examples (including teasers of some coming soon)
  • Minor cleanup/refactoring to prevent dependencies between example dirs
  • Move Escrow and Geniteam out of framework and into examples

Copy link
Contributor

@awelc awelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sam! I have just a few optional suggestions for the READMEs. These help tremendously!


Examples of toy games built on top of Sui!

* Tic Tac Toe: the pencil and paper classic, now on Sui
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with period to match other items in this list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest this throughout but don't want to be a pedant. :-)

I will gladly take care of this in a subsequent PR if you like.

@@ -0,0 +1,6 @@
# NFT's

* Geniteam: NFT's representing collectible monsters and cosmetics used in a farming game.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NFTs

(plural rather than possessive per: https://en.wikipedia.org/wiki/Non-fungible_token)

- Splitting the examples directory into several smaller directories with clearly defined themes
- Added a README to each dir with brief descriptions of the examples (including teasers of some coming soon)
- Minor cleanup/refactoring to prevent dependencies between example dirs
@sblackshear sblackshear merged commit 6add802 into MystenLabs:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants