-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move] reorganize examples directory #712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
059d7c4
to
535266e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sam! I have just a few optional suggestions for the READMEs. These help tremendously!
|
||
Examples of toy games built on top of Sui! | ||
|
||
* Tic Tac Toe: the pencil and paper classic, now on Sui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End with period to match other items in this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest this throughout but don't want to be a pedant. :-)
I will gladly take care of this in a subsequent PR if you like.
@@ -0,0 +1,6 @@ | |||
# NFT's | |||
|
|||
* Geniteam: NFT's representing collectible monsters and cosmetics used in a farming game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NFTs
(plural rather than possessive per: https://en.wikipedia.org/wiki/Non-fungible_token)
- Splitting the examples directory into several smaller directories with clearly defined themes - Added a README to each dir with brief descriptions of the examples (including teasers of some coming soon) - Minor cleanup/refactoring to prevent dependencies between example dirs
535266e
to
a0a7866
Compare
framework
and intoexamples