Clean up wallet config

[666lcz]

Not sure why we want to duplicate these code in two places. One thing that I would love to confirm with @patrickkuo or @arun-koshy is that why there's wallet.key and wallet.ks. Currently, the CLI tool will have wallet.key

sui/sui/src/sui_commands.rs

Line 57 in c3f7c73

wallet_config.keystore = KeystoreType::File(working_dir.join("wallet.key"));

while the REST server has wallet.ks

sui/sui/src/rest_server.rs

Line 233 in c3f7c73

WalletConfig::create(&working_dir.join(wallet_path)).map_err(|error| {

Is it intentional that we want to use separate files? If yes, then we should add a comment in sui_command.rs and a new parameter wallet_key_path to WalletConfig::create

sui/sui/src/config.rs

Lines 115 to 129 in c3f7c73

	impl Config for WalletConfig {
	fn create(path: &Path) -> Result<Self, anyhow::Error> {
	let working_dir = path
	.parent()
	.ok_or_else(|| anyhow!("Cannot determine parent directory."))?;
	Ok(WalletConfig {
	accounts: Vec::new(),
	keystore: KeystoreType::File(working_dir.join("wallet.ks")),
	gateway: GatewayType::Embedded(EmbeddedGatewayConfig {
	db_folder_path: working_dir.join("client_db"),
	..Default::default()
	}),
	config_path: path.to_path_buf(),
	})
	}

instead of overwriting the field

[patrickkuo]

I am working on refactoring the CLI and the rest server, starting with the configs files and keystore, I am trying to decouple rest server from wallet. The rest server is using the config files and keystore but it doesn't really need them persisted,

Can we hold this off for now?

[arun-koshy]

There is a plan in place to refactor the rest server into a rest server + rest client/wallet application.

[666lcz]

No longer needed after #817