Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bench] Fix single transaction bench #928

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Conversation

gdanezis
Copy link
Collaborator

Our logic for benching the authority with one transaction at a time (which we never do, as this is a terrible benchmark) was broken and feeding commands backwards :). This PR fixes that.

@asonnino asonnino self-requested a review March 18, 2022 15:54
Copy link
Contributor

@asonnino asonnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense to me

@gdanezis gdanezis force-pushed the fix-single-transaction-bench branch from bbcf924 to 4377677 Compare March 18, 2022 16:38
@gdanezis gdanezis merged commit b345b9c into main Mar 18, 2022
@gdanezis gdanezis deleted the fix-single-transaction-bench branch March 18, 2022 17:03
gdanezis added a commit that referenced this pull request Mar 18, 2022
mwtian pushed a commit that referenced this pull request Sep 12, 2022
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants