[move] Fix Escrow example and add tests #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
666lcz
commented
Mar 18, 2022
lxfind
reviewed
Mar 18, 2022
666lcz
force-pushed
the
chris/test-scenario
branch
2 times, most recently
from
d711686 to
75271b4
Compare
666lcz
changed the title
666lcz
commented
Mar 18, 2022
| @@ -46,7 +47,9 @@ module DeFi::Escrow { | |||
|
|
|||
| /// Trusted third party can swap compatible objects | |||
| public fun swap<T1: key + store, T2: key + store>( | |||
| obj1: EscrowedObj<T1, T2>, obj2: EscrowedObj<T1, T2> | |||
There was a problem hiding this comment.
fixed a typo here: the type for obj2 should be EscrowedObj<T2, T1> instead of EscrowedObj<T1, T2>
666lcz
force-pushed
the
chris/test-scenario
branch
3 times, most recently
from
932173c to
d9a3291
Compare
sblackshear
approved these changes
Mar 21, 2022
666lcz
force-pushed
the
chris/test-scenario
branch
from
d9a3291 to
6e9642f
Compare
mwtian
added a commit
that referenced
this pull request
Sep 12, 2022
Currently `BlockSynchronizer` steps have 2s timeout. They seem a bit short considering - Roundtrip to other nodes may take multiple secs - Other nodes may be busy - Large payload may need to be loaded from disk. For `certificates_synchronize_timeout` and `payload_availability_timeout`, only one response is needed within timeout to make progress. However 2s still seems too short. Maybe these timeouts can be 10s~20s instead.
mwtian
added a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Currently `BlockSynchronizer` steps have 2s timeout. They seem a bit short considering - Roundtrip to other nodes may take multiple secs - Other nodes may be busy - Large payload may need to be loaded from disk. For `certificates_synchronize_timeout` and `payload_availability_timeout`, only one response is needed within timeout to make progress. However 2s still seems too short. Maybe these timeouts can be 10s~20s instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the existing Escrow example and add tests. In subsequent PRs, I will implement