Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quiet Harvest noisy logs for Invalid cookie header #223

Closed
jordanpadams opened this issue Dec 4, 2024 · 1 comment · Fixed by NASA-PDS/registry-common#115
Closed

Quiet Harvest noisy logs for Invalid cookie header #223

jordanpadams opened this issue Dec 4, 2024 · 1 comment · Fixed by NASA-PDS/registry-common#115
Assignees
@al-niessner
Labels
B15.1 enhancement New feature or request i&t.skip

Comments

@jordanpadams
Copy link
Member

💡 Description

Current runs include log messages like:

Invalid cookie header: "Set-Cookie: AWSALBCORS=AF55utoZ413hKtUhG/qelRCEAMRod3Wgjh3JMUtL2fOPQdVtA8VDEAJeY47eQFJvDU3JVhryDs/cQvn2pyrNBU8DluvjtQ9wzlAWJ+Z68iNi+eRjg0Zo2Wb9dOUm; Expires=Wed, 11 Dec 2024 20:36:13 GMT; Path=/; SameSite=None; Secure". Invalid 'expires' attribute: Wed, 11 Dec 2024 20:36:13 GMT

Let's catch and quiet these log messages unless debugging is enabled.

⚔️ Parent Epic / Related Tickets

No response
@github-project-automation github-project-automation bot moved this to Sprint Backlog in B15.1 Dec 4, 2024
@jordanpadams jordanpadams changed the title Quiet Harvest noisy logs Quiet Harvest noisy logs for Invalid cookie header Dec 4, 2024
@jordanpadams jordanpadams added enhancement New feature or request and removed task labels Dec 4, 2024
@jordanpadams jordanpadams mentioned this issue Dec 4, 2024
Open
@al-niessner
Copy link
Contributor

@jordanpadams

These are not coming from our code. I think it is part of the https library that downloads the LDD.

@al-niessner al-niessner mentioned this issue Dec 4, 2024
Merged
tloubrieu-jpl added a commit to NASA-PDS/registry-common that referenced this issue Dec 11, 2024
@tloubrieu-jpl
Merge pull request #115 from NASA-PDS/harvest_223
dec554f 
NASA-PDS/harvest#223: Fix handling of missing cookie log messages
@github-project-automation github-project-automation bot moved this from ToDo to 🏁 Done in B15.1 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@al-niessner al-niessner

Labels
B15.1 enhancement New feature or request i&t.skip
Projects
B15.1
Status: 🏁 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of missing cookie log messages (see NASA-PDS/harvest#223) NASA-PDS/registry-common
2 participants
@al-niessner @jordanpadams