Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression to skip already registered products by default (see NASA-PDS/harvest#213) #108

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix regression to skip already registered products by default (see NASA-PDS/harvest#213) #108

merged 1 commit into from
Dec 16, 2024

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Nov 14, 2024 •
edited
Loading

🗒️ Summary

Remove found LIDVIDs from the correct list

⚙️ Test Data and/or Report

harvest is once again skipping files:

2024-11-14 15:33:18 [SUMMARY] (HarvestCmd.java:printSummary:280) Summary:
2024-11-14 15:33:18 [SUMMARY] (HarvestCmd.java:printSummary:283) Skipped files: 69
2024-11-14 15:33:18 [SUMMARY] (HarvestCmd.java:printSummary:284) Loaded files: 0
2024-11-14 15:33:18 [SUMMARY] (HarvestCmd.java:printSummary:294) Failed files: 0
2024-11-14 15:33:18 [SUMMARY] (HarvestCmd.java:printSummary:295) Package ID: e640ce5a-e947-4d6e-9090-eb773d7d5613

♻️ Related Issues

Closes NASA-PDS/harvest#213

@jordanpadams jordanpadams changed the title harvest 213: always overwrite Update to fix regression to skip files if already registered Nov 25, 2024
@jordanpadams
Copy link
Member

@al-niessner @tloubrieu-jpl how would I go about testing this? is there an easy method for testing something like this?

@al-niessner
Copy link
Contributor Author

@jordanpadams

Just that there are skipped messages in the summary is the test. Prior to this change that number would always be 0. Checking for the right number of skips? Run same bundle twice. First should insert. Next should skip all if overwrite is off (default for harvest).

@jordanpadams jordanpadams changed the title Update to fix regression to skip files if already registered NASA-PDS/harvest#213: Update to fix regression to skip files if already registered Dec 10, 2024
@tloubrieu-jpl
Copy link
Member

@jordanpadams @al-niessner , I am testing that now. I am doing as I believe the user found out about the issue: I update the archive-status of some files in a bundles and I reharvest the bundle. The archive-status should remain the one updated and not be reset to "staged".

tloubrieu-jpl
tloubrieu-jpl approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, thanks @al-niessner

@tloubrieu-jpl tloubrieu-jpl merged commit 19358bd into main Dec 16, 2024
3 checks passed
@tloubrieu-jpl tloubrieu-jpl deleted the harvest_213 branch December 16, 2024 21:01
@tloubrieu-jpl tloubrieu-jpl changed the title NASA-PDS/harvest#213: Update to fix regression to skip files if already registered Fix regression to skip already registered products by default (see NASA-PDS/harvest#213) Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tloubrieu-jpl tloubrieu-jpl tloubrieu-jpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

harvest by default overwrites all products
3 participants
@al-niessner @jordanpadams @tloubrieu-jpl