-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LODES ADRIO Data Estimation #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavadocMD
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! See inline; mostly small issues with the one significant request about possibly extracting a function to calculate file URLs.
JavadocMD
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
16effaf
to
484cf3b
Compare
Closed
ewilli1
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Basic Progress and Estimation Implementation. * Outlier state sizes and accounting for aux versus main files. * Added dictionary of file sizes and added average JT04-JT05 sizes. * Fixed some minor bugs, reformatted 06-05 devlog rumes. * Small readability fixes. * Small condition change. * Cache Key fix * Naming conventions fix and url generation function added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added data estimation and progress bar for downloading LODES files. Also changed the rume format for the LODES user manual (2024-06-05.ipynb) to display the progress bar and estimated download size and time.