Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LODES ADRIO Data Estimation #177

Merged
merged 8 commits into from
Oct 18, 2024
Merged

LODES ADRIO Data Estimation #177

merged 8 commits into from
Oct 18, 2024

Conversation

meaghan66
Copy link
Contributor

Added data estimation and progress bar for downloading LODES files. Also changed the rume format for the LODES user manual (2024-06-05.ipynb) to display the progress bar and estimated download size and time.

Copy link
Contributor

@JavadocMD JavadocMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! See inline; mostly small issues with the one significant request about possibly extracting a function to calculate file URLs.

@JavadocMD JavadocMD self-requested a review October 18, 2024 22:20
Copy link
Contributor

@JavadocMD JavadocMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@meaghan66 meaghan66 force-pushed the adrio-estimates-lodes branch from 16effaf to 484cf3b Compare October 18, 2024 23:30
@meaghan66 meaghan66 linked an issue Oct 18, 2024 that may be closed by this pull request
@meaghan66 meaghan66 merged commit 5a5d2ed into main Oct 18, 2024
1 check passed
@meaghan66 meaghan66 deleted the adrio-estimates-lodes branch October 18, 2024 23:49
ewilli1 pushed a commit that referenced this pull request Nov 15, 2024
* Basic Progress and Estimation Implementation.

* Outlier state sizes and accounting for aux versus main files.

* Added dictionary of file sizes and added average JT04-JT05 sizes.

* Fixed some minor bugs, reformatted 06-05 devlog rumes.

* Small readability fixes.

* Small condition change.

* Cache Key fix

* Naming conventions fix and url generation function added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADRIO progress: LODES
2 participants