Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commuting Flows ADRIO Data Estimation and Progress. #179

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

meaghan66
Copy link
Contributor

Added data estimation and progress bar functionality within the commuting flows ADRIO. Additionally added validation functions for validating the given scope and year.

@meaghan66 meaghan66 linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link
Contributor

@JavadocMD JavadocMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one more thing -- on line 147 there's a check for a special case regarding counties in Connecticut. Please move that into the scope validation method.

@JavadocMD JavadocMD self-requested a review October 22, 2024 18:51
Copy link
Contributor

@JavadocMD JavadocMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@meaghan66 meaghan66 merged commit c7195e0 into main Oct 22, 2024
1 check passed
@meaghan66 meaghan66 deleted the adrio-estimates-commuting-flows branch October 22, 2024 18:53
ewilli1 pushed a commit that referenced this pull request Nov 15, 2024
* Initial progress tracking and data estimation implementation.

* Validating scope and year functions and cleanup.

* Connecticut special cases moved to validate scope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADRIO progress: Commuting Flows
2 participants