This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The tests could not be done with
fastapi.testing.TestClient
. It turns out that there is an open bug in Starlette that has been open for over a year (encode/starlette#472), which prevents mixing middleware and Jinja2TemplateResponse
object together. The code works fine, but the unit testing fails with FastAPI'sTestClient
. The workaround (fastapi/fastapi#806) is to use theasync-asgi-testclient
package for testing.